API/ENH: tz_localize handling of nonexistent times: rename keyword + add shift option#22644
API/ENH: tz_localize handling of nonexistent times: rename keyword + add shift option#22644jreback merged 64 commits intopandas-dev:masterfrom
Conversation
|
Hello @mroeschke! Thanks for submitting the PR.
|
Codecov Report
@@ Coverage Diff @@
## master #22644 +/- ##
==========================================
+ Coverage 92.22% 92.22% +<.01%
==========================================
Files 169 169
Lines 50911 50922 +11
==========================================
+ Hits 46954 46965 +11
Misses 3957 3957
Continue to review full report at Codecov.
|
|
@jreback re: overlap between
So I would propose that eventually we can depreciate |
|
lgtm @jorisvandenbossche any more comments? |
| nonexistent : 'shift', 'NaT', default 'raise' | ||
| A nonexistent time doesn't not exist in a particular timezone | ||
| where clocks moved forward due to DST. | ||
| - 'shift' will shift the nonexistent time forward to the closest |
There was a problem hiding this comment.
Sorry, rst formatting nitpick: there needs to be a blank line between the first sentences, and the start of this list ... (getting rst right can be annoying ..)
|
Thanks @jorisvandenbossche. Added those blank lines for rendering. |
| @pytest.mark.parametrize('tz', ['Europe/Warsaw', 'dateutil/Europe/Warsaw']) | ||
| @pytest.mark.parametrize('method, exp', [ | ||
| ['shift', '2015-03-29 03:00:00'], | ||
| ['NaT', pd.NaT], |
There was a problem hiding this comment.
do you have tests that exericse the assertion when you pass a nonexistent keyword that is invalid?
There was a problem hiding this comment.
Just added a test for an invalid nonexistent keyword.
pandas/_libs/tslibs/timestamps.pyx
Outdated
|
|
||
| errors : 'raise', 'coerce', default 'raise' | ||
| nonexistent : 'shift', 'NaT', default 'raise' | ||
| A nonexistent time doesn't not exist in a particular timezone |
There was a problem hiding this comment.
| A nonexistent time doesn't not exist in a particular timezone | |
| A nonexistent time does not exist in a particular timezone |
pandas/core/arrays/datetimes.py
Outdated
|
|
||
| errors : {'raise', 'coerce'}, default 'raise' | ||
| nonexistent : 'shift', 'NaT' default 'raise' | ||
| A nonexistent time doesn't not exist in a particular timezone |
There was a problem hiding this comment.
| A nonexistent time doesn't not exist in a particular timezone | |
| A nonexistent time does not exist in a particular timezone |
pandas/core/generic.py
Outdated
| - 'raise' will raise an AmbiguousTimeError if there are ambiguous | ||
| times | ||
| nonexistent : 'shift', 'NaT', default 'raise' | ||
| A nonexistent time doesn't not exist in a particular timezone |
There was a problem hiding this comment.
| A nonexistent time doesn't not exist in a particular timezone | |
| A nonexistent time does not exist in a particular timezone |
|
Thanks for catching that typo @jorisvandenbossche |
|
one more rebase and I think ok to go |
|
thanks @mroeschke |
4 participants
git diff upstream/master -u -- "*.py" | flake8 --diffCurrently, users do not have any control over nonexistent datetime handling when
tz_localizeing like they do ambiguous times. This adds a new keywordnonexistenttotz_localizeso that users now can:'raise': Raise an error (default)'NaT': Replace nonexistent times with'NaT''shift': Shift nonexistent times forward to the closest existing time